New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NixOS: Plasma 5 tests and warnings #23388
Conversation
@ttuegel, thanks for your PR! By analyzing the history of the files in this pull request, we identified @lethalman, @edolstra and @aszlig to be potential reviewers. |
@@ -17,7 +17,8 @@ import ./make-test.nix ({ pkgs, ...} : | |||
user = "alice"; | |||
}; | |||
}; | |||
services.xserver.desktopManager.kde5.enable = true; | |||
services.xserver.desktopManager.plasma5.enable = true; | |||
services.xserver.desktopManager.default = "plasma5"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this mean users need to put this in their configuration now?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(the default = "plasma5"
bit)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This might be related: 4b6f021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If they use the auto-login feature, yes. I don't know why it is suddenly necessary.
Motivation for this change
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandbox
innix.conf
on non-NixOS)
nix-shell -p nox --run "nox-review wip"
./result/bin/
)