gnuapl: 1.6 -> 1.7 #24114
Merged
gnuapl: 1.6 -> 1.7 #24114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ndowens
suggested changes
Mar 20, 2017
|
@ndowens What is the rationale for such a refactoring? As it stands, this update looks good to me. |
|
It is just cosmetic thing I like to do, mostly just to use stdenv.lib once vs several times |
|
I have no problem doing the refactoring. I’ll to that tonight. |
|
I don't know why wait to do another PR just for cosmetic change?
…Sent from my iphone
On Mar 21, 2017, 5:28 AM -0500, Matthew Daiter ***@***.***>, wrote:
@lsix (https://github.com/lsix) @ndowens (https://github.com/ndowens) should we leave refactoring to another PR?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub (#24114 (comment)), or mute the thread (https://github.com/notifications/unsubscribe-auth/AAHL753Qk6YyaxCIiq-ew498grq0KM--ks5rn6ZMgaJpZM4MiI2-).
|
|
@ndowens it primarily makes bookkeeping easier. |
|
Idk. If you change it and commit with msg cosmetic change or so that is bookkeeping IMO and can be split to fix something if it had to be
…Sent from my iphone
On Mar 21, 2017, 6:10 AM -0500, Matthew Daiter ***@***.***>, wrote:
@ndowens (https://github.com/ndowens) it primarily makes bookkeeping easier.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub (#24114 (comment)), or mute the thread (https://github.com/notifications/unsubscribe-auth/AAHL78aOl_oVZ5YAIqU_m_4wkT4XSJodks5rn7AZgaJpZM4MiI2-).
|
Mic92
reviewed
Mar 21, 2017
|
|
||
| src = fetchurl { | ||
| url = "mirror://gnu/apl/apl-${version}.tar.gz"; | ||
| sha256 = "057zwzvvgcrrwsl52a27w86hgy31jqq6avqq629xj7yq90qah3ay"; | ||
| sha256 = "07xq8ddlmz8psvsmwr23gar108ri0lwmw0n6kpxcv8ypas1f5xlg"; | ||
| }; | ||
|
|
||
| buildInputs = [ readline gettext ncurses ]; |
There was a problem hiding this comment.
"--disable-dependency-tracking" is added by default to configure.
There was a problem hiding this comment.
I also do not see strong reason to keep the "--disable-silent-rules" (darwin only, but default behavior of automake). I’m going to drop it all together.
See http://lists.gnu.org/archive/html/info-gnu/2017-03/msg00007.html for release announcement.
fpletz
approved these changes
Mar 22, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See http://lists.gnu.org/archive/html/info-gnu/2017-03/msg00007.html
for release announcement.
Motivation for this change
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)