Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lbrynet: init at 0.9.1 #24110

Closed
wants to merge 1 commit into from
Closed

lbrynet: init at 0.9.1 #24110

wants to merge 1 commit into from

Conversation

benley
Copy link
Member

@benley benley commented Mar 20, 2017

Motivation for this change

https://lbry.io/news/20000-illegal-college-lectures-rescued

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@mention-bot
Copy link

@benley, thanks for your PR! By analyzing the history of the files in this pull request, we identified @FRidh to be a potential reviewer.

@@ -173,6 +173,15 @@ in {
};
};

base58 = buildPythonPackage rec {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you store new python packages in ./pkgs/development/python-modules and only reference them here? This is the new policy as the file has grown too big.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh yes definitely, I would prefer it that way. I thought things were moving in the opposite direction!

base58 = buildPythonPackage rec {
name = "base58-0.2.4";

srcs = pkgs.fetchurl {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does fetchPypi works here?

@@ -230,6 +239,16 @@ in {
};
};

envparse = buildPythonPackage rec {
name = "envparse-0.2.0";
src = pkgs.fetchurl {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does fetchPypi works here?

jsonrpc = buildPythonPackage rec {
name = "jsonrpc-1.2";

src = pkgs.fetchurl {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see above

miniupnpc = buildPythonPackage rec {
name = "miniupnpc-1.9";

src = pkgs.fetchurl {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see above

seccure = buildPythonPackage rec {
name = "seccure-0.3.2";

src = pkgs.fetchurl {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see above.


propagatedBuildInputs = with self; [ requests futures ];

src = pkgs.fetchurl {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see above

@FRidh
Copy link
Member

FRidh commented May 3, 2017

This has been inactive for some time so I am closing this.

@FRidh FRidh closed this May 3, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants