pypi2nix: add python3packages.setuptool buildinput #24117
Conversation
nlewo
changed the title
nlewo
changed the title
|
is this also broken in stable packages? |
|
Works for me, why is this still work in progress? |
| @@ -27,7 +27,7 @@ in stdenv.mkDerivation rec { | |||
| click | |||
| requests | |||
| ]; | |||
| buildInputs = [ python zip makeWrapper nix.out nix-prefetch-scripts ]; | |||
| buildInputs = [ python zip makeWrapper nix.out nix-prefetch-scripts python3Packages.setuptools ]; | |||
There was a problem hiding this comment.
use python.pkgs.setuptools to guarantee the correct version of setuptools is used.
There was a problem hiding this comment.
@FRidh ok, thanks, and done.
nlewo
changed the title
|
@Mic92 because I was trying to not use python3packages and to understand why it no longer works (point still not completed...). |
|
Note that it looks like @garbas prefers to fetch pyp2nix's dependencies instead of using the already available packages. |
|
as far as i understood the reason for having own package-sets is to remove the dependency on the currently changing python ecosystem edit: in nixos |
|
@nlewo can you please open a PR here: https://github.com/garbas/pypi2nix |
|
@garbas hmm... I'm not able to reproduce when I build it from the repo. |
|
@nlewo yes, most likely master already has latest setuptools. |
|
@garbas I'm really curious to understand what is happening... I tryied to build the nixpkgs packages with the current pypi2nix master but it failed (while it doens't fail when I build it from the pypi2nix repo itself). |
Fix #24111
Motivation for this change
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)