Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ODROID-XU{3,4} support #24112

Merged
merged 3 commits into from Mar 20, 2017
Merged

Add ODROID-XU{3,4} support #24112

merged 3 commits into from Mar 20, 2017

Conversation

abbradar
Copy link
Member

Motivation for this change

This enables TTL console on the multiplatform image and also builds U-Boot. Notice that the image is still not bootable out of the box; this requires non-standard modification (these boards need bootloader and uboot in the first 2KB). I don't think we want to do this with the multiplatform image (and there are also older ODROID boards which need different boot code in the same place). I think of simply packaging the sd_fuse tool; any other ideas?

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@mention-bot
Copy link

@abbradar, thanks for your PR! By analyzing the history of the files in this pull request, we identified @dezgeg and @steveej to be potential reviewers.

@dezgeg
Copy link
Contributor

dezgeg commented Mar 20, 2017

Yes, I don't add any of those bootloaders that want to be located in random sectors of the boot device to the multiplatform image, but rather expect the users to do that themselves. Reason being that there will be conflicts once multiple boards with the same SoC, and increases the risk of running some incorrect U-Boot accidentally, which could potentially (but probably unlikely) cause hardware damage.

Packaging the boot blobs separately sounds good to me.

@abbradar
Copy link
Member Author

The package is not as convenient as it may be because one doesn't usually have an ARM board to build a package for another ARM board (U-Boot is required to be built on the native platform now). Not sure if this can be done better without adding cross-compiled U-Boot derivations to nixpkgs.

@abbradar abbradar merged commit 179fe96 into NixOS:master Mar 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants