Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

yaws: erlang R17 -> R18 #24122

Merged
merged 1 commit into from Mar 20, 2017
Merged

yaws: erlang R17 -> R18 #24122

merged 1 commit into from Mar 20, 2017

Conversation

mdaiter
Copy link
Contributor

@mdaiter mdaiter commented Mar 20, 2017

Motivation for this change

Upgrade Erlang interpreter used by the yaws package from R17 to R18. The project webpage states that we must use an interpreter above R16B01. Therefore, I suggest that we remove the specification of an Erlang version to automatically update the interpreter as time/versions proceed.

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@copumpkin
Copy link
Member

Looks great, thanks!

@copumpkin copumpkin merged commit 0c1b600 into NixOS:master Mar 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants