Fix: select generic ARM C bindings when target triple is armv6, armv7l, ... #4167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes the target triple used by Crystal to select the LibC bindings when the triple specifies a specific ARM architecture, e.g. `armv6`, `armv7l` or `armv8.1-a`. refs crystal-lang#3424 (comment)
ysbaddaden
force-pushed
the
fix-arm-target-triple
branch
from
0a62d16
to
f1b5b4a
Compare
|
Raspbian (testing) provides LLVM 3.9, so I could reproduce the issue, which should now be fixed for both ARM and AArch64. |
|
Merging. The macOS Sierra failure on CI is unrelated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We don't have specific C bindings for the armv6, armv7l and other specific architectures (e.g. the
armhfDebian packages use aarmv7l-unknown-linux-gnueabihftriple). We only have bindings for the genericarmtarget, and this fix tells Crystal to always use these.Reference: #3424 (comment)