nixos/users-groups: chown home on createHome #23623
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Makes sense given the docs. Leaving the docs aside, I'd expect this beahvior if |
|
I'd say changing to |
Mic92
approved these changes
Mar 9, 2017
|
LGTM? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Fixes #23619. This should work as documented and has valid use cases.
We should fix this in both 16.09 and 17.03.
Discussion
Should we also
chmod(700)if the directory exists? In the docs it specifically says only the owner and group of the directory are modified but this could also be useful. Or should we expose an option to specify the mode?It's a bit unfortunate that the semantics of
createHomedoesn't really match its name. I thinkmanageHomewould be more fitting but not sure if the breakage is worth it. This should obviously not make it into 17.03.cc @arianvp @globin