cligh : init at 0.3, pyGithub : init at 1.32, python-jose : init at 1.3.2 #23914
Conversation
pkgs/top-level/python-packages.nix
Outdated
| @@ -5063,6 +5063,26 @@ in { | |||
| }; | |||
| }; | |||
|
|
|||
| python-jose = buildPythonPackage rec { | |||
There was a problem hiding this comment.
We have a new policy for python to put python packages into a separate file and only reference them here:
See also:
$ chromium "file://$(nix-build --no-out-link doc)//share/doc/nixpkgs/manual.html#contributing-guidelines"
There was a problem hiding this comment.
@Mic92 Thanks for your quick review. OK. I've check the new policy, and moved them to /development/python-modules/ directory.
pkgs/top-level/python-packages.nix
Outdated
| @@ -20338,6 +20357,25 @@ in { | |||
| }; | |||
| }; | |||
|
|
|||
| pyGithub = buildPythonPackage rec { | |||
pkgs/top-level/python-packages.nix
Outdated
| sha256 = "0gip9ksm0m78wd2rhv4ahdaclw5fqz1f7bpdv8y3zpq7i9crf443"; | ||
| }; | ||
| propagatedBuildInputs = with self; [ python-jose ]; | ||
| buildInput = with pkgs; [ openssl pkgconfig ]; |
There was a problem hiding this comment.
pkgconfig goes to nativeBuildInputs:
nativeBuildInputs = [ pkgconfig ];
There was a problem hiding this comment.
You're right. Anyway, both openssl and pkgconfig are found to be unnecessary so I removed the line. I do not remember why I put them in.
| { stdenv, fetchurl, pythonPackages }: | ||
|
|
||
| with pythonPackages; | ||
| buildPythonPackage rec { |
There was a problem hiding this comment.
I would use buildPythonApplication here.
| namePrefix = ""; | ||
|
|
||
| src = fetchurl { | ||
| url = "https://github.com/CMB/cligh/archive/v${version}.tar.gz"; |
There was a problem hiding this comment.
I would use fetchFromGitHub here.
There was a problem hiding this comment.
OK. I changed it to fetchFromGiHub. I thought the release archive versions may have different contents so fetchurl was used, but now I see their release archives seem to have the same content as in the git repos.
jhhuh
force-pushed
the
cligh
branch
2 times, most recently
from
1e363ef
to
2db47e3
Compare
| @@ -0,0 +1,37 @@ | |||
| diff -ru python-jose-1.3.2/requirements.txt python-jose-1.3.2.new/requirements.txt | |||
There was a problem hiding this comment.
please check the name of this file, pycyprtodome.patch
There was a problem hiding this comment.
@FRidh Thanks for your review. One stupid typo. Fixed.
| }; | ||
| patches = [ | ||
| # to use pycryptodme instead of pycrypto | ||
| ./pycyprtodome.patch |
| , buildPythonPackage, python-jose }: | ||
|
|
||
| buildPythonPackage rec { | ||
| name = "pyGithub-${version}"; |
There was a problem hiding this comment.
PyGitHub, so capital P because that's the name upstream uses.
There was a problem hiding this comment.
You're right. It is now capitalized.
….3.2 python-jose and pyGithub moved to python-module directory pyGithub : unneccessary dependencies removed minor changes: pyGithub -> PyGithub, pycyprtodome.patch -> pycryptodome.patch
|
I splitted it up into single commits, made some style changes and fixed the tests. |
Motivation for this change
Adding a new package cligh (https://github.com/cmb/cligh) and the missing dependencies.
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)