Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackage.pycassa: init at 1.11.2 #23920

Closed
wants to merge 1 commit into from
Closed

pythonPackage.pycassa: init at 1.11.2 #23920

wants to merge 1 commit into from

Conversation

nlewo
Copy link
Member

@nlewo nlewo commented Mar 15, 2017

Motivation for this change

to have it

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@mention-bot
Copy link

@nlewo, thanks for your PR! By analyzing the history of the files in this pull request, we identified @edolstra, @bjornfor, @peti and @FRidh to be potential reviewers.

FRidh
FRidh requested changes Mar 15, 2017
View reviewed changes
Copy link
Member

@FRidh FRidh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you check that tests are run?

pkgs/top-level/python-packages.nix Outdated
@@ -19676,6 +19676,23 @@ in {
};
};

pycassa = buildPythonPackage rec {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please move this to pkgs/development/python-modules/pycassa/default.nix

@nlewo
Copy link
Member Author

nlewo commented Mar 15, 2017 •
edited

@FRidh I moved it to a dedicated file. Is this now an official convention? Is there a document that mentions this convention?

Regarding tests, no test is run. They require a cassandra server up and running (https://github.com/pycassa/pycassa/tree/master/tests).

@FRidh
Copy link
Member

FRidh commented Mar 15, 2017

@FRidh I moved it to a dedicated file. Is this now an official convention? Is there a document that mentions this convention?

Its noted in the latest version of the Nixpkgs manual.

Regarding tests, no test is run. They require a cassandra server up and running (https://github.com/pycassa/pycassa/tree/master/tests).

Okay, then disable the checkPhase by passing doCheck = false; and include a comment with the reason (see also the docs for this).

@nlewo
Copy link
Member Author

nlewo commented Mar 15, 2017

I commented why doCheck = false.
And since pycassa doens't support python3, I disabled it.

Mic92
Mic92 reviewed Mar 16, 2017
View reviewed changes
pkgs/development/python-modules/pycassa/default.nix
buildPythonPackage rec {
version = "1.11.2";
name = "pycassa-${version}";
src = fetchurl {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I changed that to fetchPypi

@Mic92 Mic92 closed this in f28fe4c Mar 16, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mic92 Mic92 Mic92 left review comments

@FRidh FRidh FRidh requested changes

Assignees
No one assigned
Labels
6.topic: python 8.has: package (update)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@nlewo @mention-bot @FRidh @Mic92