gitkraken: init at 2.1.0 #23459
Merged
gitkraken: init at 2.1.0 #23459
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bjornfor
requested changes
Mar 5, 2017
lib/maintainers.nix
Outdated
| @@ -353,6 +353,7 @@ | |||
| notthemessiah = "Brian Cohen <brian.cohen.88@gmail.com>"; | |||
| np = "Nicolas Pouillard <np.nix@nicolaspouillard.fr>"; | |||
| nslqqq = "Nikita Mikhailov <nslqqq@gmail.com>"; | |||
| nwdd = "Guillermo NWDD <nwdd+nixos@no.team>"; | |||
There was a problem hiding this comment.
Is that a real email address?
There was a problem hiding this comment.
Please add your entry to maintainers.nix in a separate commit.
There was a problem hiding this comment.
@bjornfor It's real, feel free to drop me a line.
| @@ -0,0 +1,69 @@ | |||
| {stdenv, lib, libXcomposite, libgnome_keyring, makeWrapper, udev, curl, fetchurl, libXfixes, atk, gtk2, libXrender, pango, gnome2, cairo, freetype, fontconfig, libX11, libXi, libXext, libXcursor, glib, libXScrnSaver, libxkbfile, libXtst, nss, nspr, cups, alsaLib, expat , gdk_pixbuf, libXdamage, libXrandr, dbus}: | |||
There was a problem hiding this comment.
Please wrap overlong lines using the following style:
{ stdenv, .......
, foo, .....
}:
EDIT: semicolon -> colon typo
| phases = [ "unpackPhase" "installPhase" ]; | ||
| buildInputs = [ makeWrapper ]; | ||
|
|
||
| installPhase = '' |
There was a problem hiding this comment.
Please indent the string in installPhase:
installPhase = ''
mkdir -p "$out/opt/gitkraken"
...
'';
| ln -s "$out/opt/gitkraken/gitkraken" "$out/bin/gitkraken" | ||
| ''; | ||
|
|
||
| meta = { |
There was a problem hiding this comment.
If you write meta = with stdenv.lib; { you can drop all the stdenv.lib things inside meta.
grahamc
requested changes
Mar 7, 2017
| description = "The downright luxurious and most popular Git client for Windows, Mac & Linux"; | ||
| license = licenses.unfreeRedistributable; | ||
| platforms = platforms.linux; | ||
| maintainers = [ ]; |
| meta = with stdenv.lib; { | ||
| homepage = https://www.gitkraken.com/; | ||
| description = "The downright luxurious and most popular Git client for Windows, Mac & Linux"; | ||
| license = licenses.unfreeRedistributable; |
There was a problem hiding this comment.
I don't think the license allows us to redistribute.
There was a problem hiding this comment.
It's actually the other way round. This would allow us to distribute the binaries.
But their EULA states distribution is prohibited, so this should be licenses.unfree.
|
That is what I meant to say :)
…On Mon, Mar 6, 2017 at 9:35 PM Franz Pletz ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In pkgs/applications/version-management/gitkraken/default.nix
<#23459 (comment)>:
> + mkdir -p "$out/opt/gitkraken"
+ cp -r ./* "$out/opt/gitkraken"
+ fixupPhase
+ patchelf --set-interpreter $(cat $NIX_CC/nix-support/dynamic-linker) \
+ --set-rpath "$libPath:$out/opt/gitkraken" "$out/opt/gitkraken/gitkraken"
+ wrapProgram $out/opt/gitkraken/gitkraken \
+ --prefix LD_PRELOAD : "${stdenv.lib.makeLibraryPath [ curl ]}/libcurl.so.4" \
+ --prefix LD_PRELOAD : "${stdenv.lib.makeLibraryPath [ libgnome_keyring ]}/libgnome-keyring.so.0"
+ mkdir "$out/bin"
+ ln -s "$out/opt/gitkraken/gitkraken" "$out/bin/gitkraken"
+ '';
+
+ meta = with stdenv.lib; {
+ homepage = https://www.gitkraken.com/;
+ description = "The downright luxurious and most popular Git client for Windows, Mac & Linux";
+ license = licenses.unfreeRedistributable;
It's actually the other way round. This would allow us to distribute the
binaries.
But their EULA <https://www.gitkraken.com/eula> states distribution is
prohibited, so this should be licenses.unfree.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#23459 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAErrH16vCbbKixFr2R1Vyn2qfzg_i74ks5rjMJigaJpZM4MSwsW>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)