Basic test for the PileUp #1221
Merged
+505
−125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eggrobin
reviewed
Mar 4, 2017
| @@ -33,7 +33,7 @@ using quantities::Mass; | |||
| // A |PileUp| handles a connected component of the graph of |Parts| under | |||
| // physical contact. It advances the history and prolongation of its component | |||
| // |Parts|, modeling them as a massless body at their centre of mass. | |||
| class PileUp final { | |||
| class PileUp { | |||
There was a problem hiding this comment.
Why not final? In that case, have a virtual destructor.
There was a problem hiding this comment.
Because of TestablePileUp. Done.
eggrobin
reviewed
Mar 4, 2017
ksp_plugin/pile_up.hpp
Outdated
| // on the origin of |Bubble| given in |Barycentric|, and on the |RigidPileUp| | ||
| // degrees of freedom of the parts (as set by |DeformPileUpIfNeeded|). | ||
| // Adjusts the degrees of freedom of all parts in this pile up based on the | ||
| // position of the pile-up computed by |AdvanceTime| and on the |RigidPileUp| |
There was a problem hiding this comment.
position? isn't this degrees of freedom?
eggrobin
requested changes
Mar 4, 2017
ksp_plugin_test/pile_up_test.cpp
Outdated
| 0.0 * Metre / Second, | ||
| -20.0 / 3.0 * Metre / Second}), 0))); | ||
|
|
||
| pile_up.DeformPileUpIfNeeded(); |
There was a problem hiding this comment.
This should not be part of a function that checks invariants.
eggrobin
approved these changes
Mar 4, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.