tldr: 1.2.0 -> 1.3.0 #23465
Merged
tldr: 1.2.0 -> 1.3.0 #23465
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@c0bw3b, thanks for your PR! By analyzing the history of the files in this pull request, we identified @nckx and @Radvendii to be potential reviewers. |
matthiasbeyer
approved these changes
Mar 5, 2017
joachifm
reviewed
Mar 5, 2017
pkgs/tools/misc/tldr/default.nix
Outdated
| @@ -18,10 +18,10 @@ stdenv.mkDerivation rec { | |||
|
|
|||
| meta = with stdenv.lib; { | |||
| description = "Simplified and community-driven man pages"; | |||
| longDescription = '' | |||
| longDescription = " | |||
There was a problem hiding this comment.
Note that it makes the indentation remain in the string...
There was a problem hiding this comment.
It was clearer to me that way because of the single quote in the description.
There was a problem hiding this comment.
I see. It is customary to use indented strings for long descriptions, however.
|
Now we have two commits. Please squash them! |
Corrected longDescription
|
Squashed. |
vcunat
approved these changes
Mar 6, 2017
pkgs/tools/misc/tldr/default.nix
Outdated
| @@ -18,10 +18,10 @@ stdenv.mkDerivation rec { | |||
|
|
|||
| meta = with stdenv.lib; { | |||
| description = "Simplified and community-driven man pages"; | |||
| longDescription = '' | |||
| longDescription = " | |||
There was a problem hiding this comment.
Note that it makes the indentation remain in the string...
|
I squash-merged anyway... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Package update
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)