Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

uriparser: 0.8.2 -> 0.8.4 + fixed build #23456

Closed
wants to merge 2 commits into from
Closed

uriparser: 0.8.2 -> 0.8.4 + fixed build #23456

wants to merge 2 commits into from

Conversation

c0bw3b
Copy link
Contributor

@c0bw3b c0bw3b commented Mar 3, 2017

Motivation for this change

Minor version bump + removed the creation of the HTML API documentation because :

  1. it is available online on the website of the project
  2. it requires doxygen, graphviz and qhelpgenerator which is part of the whole Qt framework...

This should be pushed to release-17.03 as part of #23253

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@c0bw3b
uriparser: 0.8.2 -> 0.8.4 + fixed build
eb75ff4 
Minor version bump + removed doc
@mention-bot
Copy link

@c0bw3b, thanks for your PR! By analyzing the history of the files in this pull request, we identified @bosu and @zimbatm to be potential reviewers.

@c0bw3b
Copy link
Contributor Author

c0bw3b commented Mar 3, 2017

Running the bin from the package :

[demo@nixos:~/testbuild/uriparser]$ ./result/bin/uriparse https://nixos.org/nixos/security.html
uri:          https://nixos.org/nixos/security.html
scheme:       https
hostText:     nixos.org
 .. pathSeg:  nixos
 .. pathSeg:  security.html
absolutePath: false

@bjornfor
Copy link
Contributor

bjornfor commented Mar 4, 2017

The commit message needs an explanation why removing the docs is a good thing. (It generally isn't :-) )

@c0bw3b
uriparser: 0.8.2 -> 0.8.4
b79306d 
Minor version bump.
Fixed the Makefile for the doc : there is no .map files to install in this release since dot outputs images in PNG and SVG
@c0bw3b
Copy link
Contributor Author

c0bw3b commented Mar 4, 2017

@bjornfor Fair point.

I've reworked this and figured out what was blocking the build from the doc Makefile.

@Mic92 Mic92 closed this in f39e718 Mar 6, 2017
Mic92 pushed a commit that referenced this pull request Mar 6, 2017
@c0bw3b @Mic92
uriparser: 0.8.2 -> 0.8.4
c7509af 
Fixed the Makefile for the doc : there is no .map files to install in
this release since dot outputs images in PNG and SVG

fixes #23456

(cherry picked from commit f39e718)
@c0bw3b c0bw3b deleted the pkg/uriparser branch March 9, 2017 00:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@c0bw3b @mention-bot @bjornfor