Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pdnsd: fix darwin build #23567

Merged
merged 1 commit into from Mar 10, 2017
Merged

pdnsd: fix darwin build #23567

merged 1 commit into from Mar 10, 2017

Conversation

LnL7
Copy link
Member

@LnL7 LnL7 commented Mar 6, 2017 •
edited

Motivation for this change
Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@LnL7 LnL7 added the 6.topic: darwin Running or building packages on Darwin label Mar 6, 2017
@mention-bot
Copy link

@LnL7, thanks for your PR! By analyzing the history of the files in this pull request, we identified @jwiegley, @nfjinjing and @Fuuzetsu to be potential reviewers.

@c0bw3b
Copy link
Contributor

c0bw3b commented Mar 7, 2017

Could we use this PR to also fix the homepage URL as an added bonus ?

It should be http://members.home.nl/p.a.rombouts/pdnsd/
Or perhaps https://gitorious.org/pdnsd/pdnsd if Gitorious seems more reliable over time.

@LnL7 LnL7 merged commit f0f77af into NixOS:master Mar 10, 2017
@LnL7 LnL7 deleted the darwin-pdnsd branch March 10, 2017 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: darwin Running or building packages on Darwin
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@LnL7 @mention-bot @c0bw3b