Test the things #1230
Merged
Test the things #1230
+62
−32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pleroy
reviewed
Mar 6, 2017
ksp_plugin/plugin.cpp
Outdated
| current_time_(solar_system_epoch) {} | ||
|
|
||
| void Plugin::InsertCelestialAbsoluteCartesian( | ||
| current_time_(solar_system_epoch) {}void Plugin::InsertCelestialAbsoluteCartesian( |
ksp_plugin/plugin.cpp
Outdated
| @@ -141,6 +139,21 @@ void Plugin::InsertCelestialAbsoluteCartesian( | |||
| initial_state); | |||
| } | |||
|
|
|||
| Plugin::~Plugin() { | |||
| // This is largely awful; If we simply let the destructor of |Part| deal with | |||
There was a problem hiding this comment.
Remove the awful, bad, very sad adjectives.
serialization/ksp_plugin.proto
Outdated
| repeated Part parts = 14; | ||
| repeated uint32 kept_parts = 15; | ||
| required DiscreteTrajectory psychohistory = 16; | ||
| required bool psychohistory_is_authoritative = 17; | ||
| required DiscreteTrajectory prediction = 18; | ||
| optional FlightPlan flight_plan = 4; | ||
|
|
||
| reserved 13; | ||
| reserved "dummy_part"; | ||
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix some bug and uncover others; the C# has some traces that I'm going to need as soon as things stop crashing below it, so I'm keeping them; the INFO traces on the C++ should stay, because they're for part creation/transfer/destruction, which should not be overly spammy.