pump.io 2.1.1 #23568
Closed
pump.io 2.1.1 #23568
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@rvl, thanks for your PR! By analyzing the history of the files in this pull request, we identified @svanderburg, @abbradar and @FRidh to be potential reviewers. |
|
Yes it can be cherry-picked to 17.03. There is also 3.0 already released: https://github.com/pump-io/pump.io/releases How do I use pumpio? If I start it from commandline: it does not open a socket on localhost:31337. |
|
Thanks @Mic92 I will add the 3.0 release to this PR. There are some config file changes for this version which I will need to test. To use pump.io, you need to run a database and configure |
The package stopped building for some unknown reason (npm could no longer fetch a module). This is one of the build failures listed in NixOS#23253. http://hydra.nixos.org/build/49551309 http://hydra.nixos.org/build/49548753 Easiest fix is to upgrade to latest stable version and regenerate packages with node2nix. The databank-memcached dependency needed to be dropped due to dependency failures.
JS devs found a new way to be annoying - adjust code accordingly. Have also put this change in PR svanderburg/node2nix#40
These changes are backwards compatible.
Added extra config options to allow reading passwords from file rather than the world-readable nix store. The full config.json file is created at service startup. Relevant to NixOS#18881
|
I applied your fixes with some minor style changes and made "localhost" the default value of |
|
Most excellent, thanks @Mic92 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Package was broken and new stable releases have been made.
Could this also be cherry-picked onto
release-17.03please?Relevant to #23253.
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)