New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mypy #23565
Mypy #23565
Conversation
@teh, thanks for your PR! By analyzing the history of the files in this pull request, we identified @martingms, @wizeman and @FRidh to be potential reviewers. |
pkgs/top-level/python-packages.nix
Outdated
@@ -32038,6 +32038,26 @@ EOF | |||
}; | |||
}; | |||
|
|||
typed-ast = buildPythonPackage rec { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you put this in `pkgs/development/python-modules/typed-ast/default.nix
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done.
Is the plan to create a new file for every new module?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Might be worth sending a mail to the mailing list! I think I missed the discussion :)
pkgs/top-level/python-packages.nix
Outdated
|
||
# Only works with Python 3.3 and newer; | ||
disabled = !isPy3k && !(pythonOlder "3.3"); | ||
propagatedBuildInputs = [ python ]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no need for python here
pkgs/top-level/python-packages.nix
Outdated
url = "mirror://pypi/t/typed-ast/${name}.zip"; | ||
sha256 = "10srza5ycwzdirbgd68z0zkw7i4yd3wic1qmp00274lqajh7ixdm"; | ||
}; | ||
buildInputs = [ pkgs.unzip ]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
don't we typically use fetchzip?
PTAL |
Motivation for this change
mypy has changed its name and versioning scheme
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandbox
innix.conf
on non-NixOS)
nix-shell -p nox --run "nox-review wip"
./result/bin/
)