Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

facebook-purple: 2016-04-09 -> 0.9.0 #23570

Merged
merged 1 commit into from Mar 7, 2017
Merged

Conversation

Mic92
Copy link
Member

@Mic92 Mic92 commented Mar 6, 2017

Motivation for this change

fix build. ping @davorb for testing
related to #23253

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@Mic92 Mic92 changed the title Facebook purple facebook-purple: fix build Mar 6, 2017
@Mic92 Mic92 changed the title facebook-purple: fix build facebook-purple: 2016-04-09 -> 0.9.0 Mar 6, 2017
@NeQuissimus NeQuissimus merged commit 9fa7a3a into NixOS:master Mar 7, 2017
@Mic92
Copy link
Member Author

Mic92 commented Mar 8, 2017

Need also to be back ported to 17.03

@Mic92 Mic92 deleted the facebook-purple branch March 8, 2017 12:12
@Mic92 Mic92 added the 9.needs: port to stable A PR needs a backport to the stable release. label Mar 8, 2017
@davorb
Copy link
Contributor

davorb commented Mar 10, 2017

Sorry, I no longer have access to a Nix-machine, so it will be hard for me to fix this. I suggest removing the package.

@samueldr samueldr removed the 9.needs: port to stable A PR needs a backport to the stable release. label Apr 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants