New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dnsmasq: install launchd plist on darwin #23578
Conversation
@nicknovitski, thanks for your PR! By analyzing the history of the files in this pull request, we identified @wkennington, @fpletz and @tailhook to be potential reviewers. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but I don't have a Mac so I don't know how this is supposed to work. 😄
@@ -39,6 +39,11 @@ stdenv.mkDerivation rec { | |||
# module can create it in Nix-land? | |||
postInstall = '' | |||
install -Dm644 trust-anchors.conf $out/share/dnsmasq/trust-anchors.conf | |||
'' + optionalString stdenv.isDarwin '' | |||
install -Dm644 contrib/MacOSX-launchd/uk.org.thekelleys.dnsmasq.plist \ | |||
$out/System/Library/LaunchDaemons/uk.org.thekelleys.dnsmasq.plist |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm pretty sure most other packages that have something like this put it in $out/Library/LaunchDaemons
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Huh, you're right, I found two that use Library
and only one that used System/Library
. Guess I didn't look closely enough the first time. I'll change my patch to match the majority.
a249b4d
to
44cf3c4
Compare
@LnL7 pointed out most packages put plist files in just |
Well that sucks. |
What's that from? |
Those seem to be the causes of the current build failures. |
It's just a static file in the
contrib
folder of the project's source, added as an output inSystem/Library/LaunchDaemons
(I copied this from a few other packages), with its path corrected.