Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nodejs-7_x: 7.7.2 -> 7.7.3 #24156

Merged
merged 1 commit into from Mar 22, 2017
Merged

nodejs-7_x: 7.7.2 -> 7.7.3 #24156

merged 1 commit into from Mar 22, 2017

Conversation

smolak
Copy link

@smolak smolak commented Mar 21, 2017

Motivation for this change

Update NodeJS version.

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@mention-bot
Copy link

@smolak, thanks for your PR! By analyzing the history of the files in this pull request, we identified @cko and @ben-z to be potential reviewers.

ben-z
ben-z approved these changes Mar 21, 2017
View reviewed changes
Copy link
Contributor

@ben-z ben-z left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚢 🇮🇹 = :shipit:

@smolak
Copy link
Author

smolak commented Mar 21, 2017 •
edited

Originally I have used SHA256 hash from node's FTP site. I have changed it to one generated by nix-prefetch-url.

@fpletz fpletz merged commit 07e6fe3 into NixOS:master Mar 22, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ben-z ben-z ben-z approved these changes

Assignees
No one assigned
Labels
8.has: package (update) 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@smolak @mention-bot @ben-z @pSub @fpletz @Janik-Haag