Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

riak: switch interpreter version #24157

Merged
merged 1 commit into from Mar 21, 2017
Merged

riak: switch interpreter version #24157

merged 1 commit into from Mar 21, 2017

Conversation

mdaiter
Copy link
Contributor

@mdaiter mdaiter commented Mar 21, 2017 •
edited

Motivation for this change

The official Riak docs recommend using the Basho fork of the R16B02 interpreter. We should use this instead of the R16 interpreter.

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@mention-bot
Copy link

@mdaiter, thanks for your PR! By analyzing the history of the files in this pull request, we identified @cstrahan, @fpletz and @globin to be potential reviewers.

@mdaiter mdaiter mentioned this pull request Mar 21, 2017
Closed
@LnL7
Copy link
Member

LnL7 commented Mar 21, 2017

I thought this already used the basho version 😄

LnL7
LnL7 approved these changes Mar 21, 2017
View reviewed changes
Copy link
Member

@LnL7 LnL7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you should add yourself to the maintainers, if you want

@mdaiter
Copy link
Contributor Author

mdaiter commented Mar 21, 2017

@LnL7 lol, it was the only Riak package in the Riak ecosystem I hadn't swapped yet! Didn't want to cause unnecessary change 😛
Maintainer of the package?

@LnL7
Copy link
Member

LnL7 commented Mar 21, 2017

If you add an entry to meta.maintainers you'll get an email from hydra if something breaks and people can use it to mention you in issues.

@mdaiter
Copy link
Contributor Author

mdaiter commented Mar 21, 2017

@LnL7 I'll do it in a separate PR. Easier for bookkeeping.

@LnL7 LnL7 merged commit 4ea01af into NixOS:master Mar 21, 2017
@mdaiter mdaiter deleted the riakTouchups branch March 21, 2017 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LnL7 LnL7 LnL7 approved these changes

Assignees
No one assigned
Labels
6.topic: erlang
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mdaiter @mention-bot @LnL7