Skip to content

Names #1276

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Mar 21, 2017
Merged

Names #1276

merged 9 commits into from
Mar 21, 2017

Conversation

eggrobin
Copy link
Member

  • use the right part names Part.partName is always "Part", part.name corresponds to ProtoPartSnapshot.partName;
  • vessel renaming;
  • remove a spammy serialization log;
  • log on vessel destruction---this one is spammy, but I don't understand why? we should look into that;
  • an improvised correction for physicalObjects;
  • a TODO with a suggestion for the asteroid issue.

eggrobin added 8 commits March 21, 2017 11:49
@eggrobin
use the name that's not Part and remove a spammy trace
d3c0324
@eggrobin
vessel renaming and a trace on destruction

Partially verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
We cannot verify signatures from co-authors, and some of the co-authors attributed to this commit require their commits to be signed.
eb7240d
@eggrobin
TODO

Partially verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
We cannot verify signatures from co-authors, and some of the co-authors attributed to this commit require their commits to be signed.
8e5a13d
@eggrobin
I don't know whether this is better
5a40d19
@eggrobin
killing the gravitic thing is a bad idea, it makes the non-part thing…
ea71f5a 
…s (physicalObjects) fly everywhere. Maybe someday we should handle those, but that seems really tedious
@eggrobin
This does not fix the issue, so let's revert it
b876eb9 
This reverts commit ea71f5a.
@eggrobin
blarg.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
8c23581 
This reverts commit 5a40d19.
@eggrobin
handwave a correction for physicalObjects
c492293
pleroy
pleroy reviewed Mar 21, 2017
View reviewed changes
ksp_plugin/vessel.cpp Outdated
return name_;
}

void Vessel::rename(std::string const& new_name) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

set_name?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@pleroy pleroy added the LGTM label Mar 21, 2017
@eggrobin eggrobin merged commit d45cafb into mockingbirdnest:master Mar 21, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pleroy pleroy

Assignees
No one assigned
Labels
LGTM
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@eggrobin @pleroy