Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add specs for #4163 #4171

Merged
merged 1 commit into from Mar 21, 2017
Merged

Add specs for #4163 #4171

merged 1 commit into from Mar 21, 2017

Conversation

Sija
Copy link
Contributor

@Sija Sija commented Mar 21, 2017 •
edited

Followup to #4163.

@bcardiff
Copy link
Member

@Sija I think the specs overlaps too much with #3958 and the already existing specs. The sample programs are fine though.

What do you think of asserting that something was written in STDERR and STDOUT remains (mostly?) empty?

@Sija
Copy link
Contributor Author

Sija commented Mar 21, 2017

@bcardiff sounds cushtie with me, pushed updates.

@bcardiff bcardiff added this to the Next milestone Mar 21, 2017
@bcardiff bcardiff merged commit e4d1f92 into crystal-lang:master Mar 21, 2017
@bcardiff
Copy link
Member

#TIL cushtie. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
kind:refactor topic:stdlib
Projects
None yet
Milestone
0.22.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Sija @bcardiff