New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mesa: enable texture floats by default #24162
Conversation
@abbradar, thanks for your PR! By analyzing the history of the files in this pull request, we identified @corngood, @vcunat and @wkennington to be potential reviewers. |
Hmm, if we want to open path for the future option, better set this to |
I think this is a good step for now. Do we have any examples of things that are left to user choice, but are built in multiple configurations to the binary cache? We could have some sort of global patent flag similar to the unfree one, except both versions would go in the cache. Would we just have to add |
I thought to change this according to @vcunat's comment but it shouldn't be a problem anyway if this flag has no effect on core Mesa. |
@corngood: attributes in |
I have no idea if the patent risk applies to running the code or to having it on your drive or what... (or even if this is in libGL or where) |
@vcunat Not a lawyer too. Well, we can just make a more accurate patch during next Mesa update. |
I'm just about to update it ;-) |
See 328bcda |
I wonder whether to backport this to 17.03... yes? |
I guess so, done in 0c06c48. |
Motivation for this change
Fixes #24116, see it for discussion.
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandbox
innix.conf
on non-NixOS)
nix-shell -p nox --run "nox-review wip"
./result/bin/
)I haven't tried to build it! Presuming it's okay since this is a used option.