Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mesa: enable texture floats by default #24162

Merged
merged 1 commit into from Mar 21, 2017
Merged

Conversation

abbradar
Copy link
Member

Motivation for this change

Fixes #24116, see it for discussion.

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

I haven't tried to build it! Presuming it's okay since this is a used option.

@mention-bot
Copy link

@abbradar, thanks for your PR! By analyzing the history of the files in this pull request, we identified @corngood, @vcunat and @wkennington to be potential reviewers.

@abbradar abbradar changed the base branch from master to staging March 21, 2017 13:01
@vcunat
Copy link
Member

vcunat commented Mar 21, 2017

Hmm, if we want to open path for the future option, better set this to true only in mesa_drivers.

@corngood
Copy link
Contributor

I think this is a good step for now.

Do we have any examples of things that are left to user choice, but are built in multiple configurations to the binary cache? We could have some sort of global patent flag similar to the unfree one, except both versions would go in the cache. Would we just have to add mesa_drivers_nopatent to all-packages?

@edolstra edolstra merged commit 98624f4 into NixOS:staging Mar 21, 2017
@abbradar
Copy link
Member Author

I thought to change this according to @vcunat's comment but it shouldn't be a problem anyway if this flag has no effect on core Mesa.

@vcunat
Copy link
Member

vcunat commented Mar 21, 2017

@corngood: attributes in all-packages.nix are the main place, but we only do this for leaf packages. For fontconfig, for example, we can't afford to build the whole reverse closure twice. (One could do some hacky replacing, etc. but I don't like that.)

@vcunat
Copy link
Member

vcunat commented Mar 21, 2017

I have no idea if the patent risk applies to running the code or to having it on your drive or what... (or even if this is in libGL or where)

@abbradar
Copy link
Member Author

@vcunat Not a lawyer too. Well, we can just make a more accurate patch during next Mesa update.

@vcunat
Copy link
Member

vcunat commented Mar 21, 2017

I'm just about to update it ;-)

@abbradar
Copy link
Member Author

See 328bcda

@vcunat
Copy link
Member

vcunat commented Mar 21, 2017

I wonder whether to backport this to 17.03... yes?

@abbradar
Copy link
Member Author

I guess so, done in 0c06c48.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants