Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: NixOS/nix
base: 3f35612c041e
Choose a base ref
...
head repository: NixOS/nix
compare: 558eda01154d
Choose a head ref
  • 8 commits
  • 17 files changed
  • 1 contributor

Commits on Mar 16, 2017

  1. nix-copy-closure: Fix assertion failure 

      $ ./inst/bin/nix-copy-closure --to bla $(type -p firefox)
  nix-copy-closure: src/libstore/store-api.cc:80: std::__cxx11::string nix::storePathToHash(const Path&): Assertion `base.size() >= storePathHashLen' failed.
    @edolstra
    edolstra committed Mar 16, 2017
    Configuration menu
    Copy the full SHA
    43f158b View commit details
    Browse the repository at this point in the history

  2. Remove "killing process <pid>" messages 

    They convey no useful information.
    @edolstra
    edolstra committed Mar 16, 2017
    Configuration menu
    Copy the full SHA
    0ec7f47 View commit details
    Browse the repository at this point in the history

  3. Fix nix-copy-closure --to

    @edolstra
    edolstra committed Mar 16, 2017
    Configuration menu
    Copy the full SHA
    7a716ef View commit details
    Browse the repository at this point in the history

  4. LegacySSHStore: Provide a faster implementation of computeFSClosure() 

    This avoids the latency of the standard implementation, which can make
a huge difference (e.g. 16.5s -> 0.5s on a NixOS system closure).
    @edolstra
    edolstra committed Mar 16, 2017
    Configuration menu
    Copy the full SHA
    ea7fa88 View commit details
    Browse the repository at this point in the history

  5. copyPaths(): Don't query path info for a path the target already has 

    For example, this cuts "nix-copy-closure --from" on a NixOS system
closure from 15.9s to 0.5s.
    @edolstra
    edolstra committed Mar 16, 2017
    Configuration menu
    Copy the full SHA
    91d6769 View commit details
    Browse the repository at this point in the history

  6. copyPaths(): Use queryValidPaths() to reduce SSH latency

    @edolstra
    edolstra committed Mar 16, 2017
    Configuration menu
    Copy the full SHA
    c5b83d8 View commit details
    Browse the repository at this point in the history

  7. ssh:// -> ssh-ng://, legacy-ssh:// -> ssh://

    @edolstra
    edolstra committed Mar 16, 2017
    Configuration menu
    Copy the full SHA
    287084d View commit details
    Browse the repository at this point in the history

  8. nix copy: Make -r option use the "from" store 

    Previously, we tried to compute the closure in the local store, which
obviously doesn't work.
    @edolstra
    edolstra committed Mar 16, 2017
    Configuration menu
    Copy the full SHA
    558eda0 View commit details
    Browse the repository at this point in the history