Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pdfpc, libgee_0_8: Add darwin support #23954

Merged
merged 2 commits into from Mar 17, 2017
Merged

pdfpc, libgee_0_8: Add darwin support #23954

merged 2 commits into from Mar 17, 2017

Conversation

jbaum98
Copy link
Contributor

@jbaum98 jbaum98 commented Mar 16, 2017

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@mention-bot
Copy link

@jbaum98, thanks for your PR! By analyzing the history of the files in this pull request, we identified @pSub to be a potential reviewer.

@LnL7 LnL7 added the 6.topic: darwin Running or building packages on Darwin label Mar 16, 2017
@LnL7
Copy link
Member

LnL7 commented Mar 16, 2017

I think the platforms for one of the dependencies should also be updated.

Package ‘libgee-0.18.0’ in ‘/nix/store/8fzb0a1y40fc61ar3585ajp1vxkb3x30-git-export/pkgs/desktops/gnome-3/3.22/core/libgee/default.nix:21’ is not supported on ‘x86_64-darwin’, refusing to evaluate.

@jbaum98 jbaum98 changed the title pdfpc: Add darwin support pdfpc, linger: Add darwin support Mar 16, 2017
@jbaum98 jbaum98 changed the title pdfpc, linger: Add darwin support pdfpc, liege: Add darwin support Mar 16, 2017
@jbaum98 jbaum98 changed the title pdfpc, liege: Add darwin support pdfpc, libgee: Add darwin support Mar 16, 2017
@jbaum98
Copy link
Contributor Author

jbaum98 commented Mar 16, 2017

Sorry about the many name changes. Autocorrect got me twice. Thanks @LnL7.

@LnL7
Copy link
Member

LnL7 commented Mar 16, 2017 •
edited

It looks like it's actually using gnome3.libgee-0.18.0, not sure why that isn't defined top-level.

@jbaum98 jbaum98 changed the title pdfpc, libgee: Add darwin support pdfpc, libgee_0_8: Add darwin support Mar 16, 2017
@jbaum98
Copy link
Contributor Author

jbaum98 commented Mar 16, 2017

I found it in all-packages.nix as libgee_0_8.

@LnL7
Copy link
Member

LnL7 commented Mar 16, 2017

Yes, but that's actually another file https://search.nix.gsc.io/?q=libgee-&i=nope&files=&repos=

@jbaum98
Copy link
Contributor Author

jbaum98 commented Mar 16, 2017 •
edited

Ohh my bad. I see that I've updated the wrong file. I'll get rid of that commit.

@LnL7 LnL7 merged commit 6f226a8 into NixOS:master Mar 17, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LnL7 LnL7 LnL7 approved these changes

Assignees
No one assigned
Labels
6.topic: darwin Running or building packages on Darwin
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jbaum98 @mention-bot @LnL7