lilypond: add openlilylib-fonts and lilypond-with-fonts #23548

yurrriq · 2017-03-06T08:21:11Z

Motivation for this change

I want to use some custom music fonts, which LilyPond supports but needs for them to be in a particular location.

Notes

I feel like the code I've written is a bit sloppy and I'm very open to suggestions.

Example:

{
  nixpkgs.config.packageOverrides = pkgs: rec {
    my-lilypond = pkgs.lilypond-with-fonts(with pkgs.openlilylib-fonts; [
      improviso
      lilyjazz
    ]);
}

Edit:

{
    my-lilypond = pkgs.lilypond-with-fonts.override {
      fonts = with pkgs.openlilylib-fonts; [ improviso lilyjazz ];
    };
}

Things done

Tested using sandboxing
(nix.useSandbox on NixOS,
or option build-use-sandbox in nix.conf
on non-NixOS)
Built on platform(s)
- NixOS
- macOS
- Linux
Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
Tested execution of all binary files (usually in ./result/bin/)
Fits CONTRIBUTING.md.

yurrriq · 2017-03-06T08:21:44Z

pkgs/misc/lilypond/fonts.nix

+in
+
+{
+  beethoven = olpFont {


I assembled this mostly manually. It should probably be scripted.

Probably ok for the moment.

yurrriq · 2017-03-06T08:23:24Z

pkgs/misc/lilypond/with-fonts.nix

+      install -m755 -Dt $out/bin ${lilypond}/bin/*
+
+      for p in $out/bin/*; do
+        substituteInPlace $p --replace "exec -a ${lilypond}" "exec -a $out"


This works, but feels very hackish. The lilypond binary seems to look for fonts in ../share/lilypond/${lilypond.version}/fonts so simply symlinking the original, doesn't work.

I currently do not see a different solution.

yurrriq · 2017-03-06T08:26:38Z

/cc @puffnfresh @Mic92

Mic92 · 2017-03-06T09:52:39Z

pkgs/misc/lilypond/with-fonts.nix

@@ -0,0 +1,28 @@
+{ stdenv, lilypond, lndir }: fonts: stdenv.mkDerivation {


Could be the default value just use all OpenLilyPondFonts? Some people just want to get something working without having to override a package. Maybe an all attribute containing a list of all fonts.

Add a list of all fonts to openlilylib-fonts and use that as the default fonts argument to lilypond-with-fonts.

Mic92 · 2017-03-06T13:37:31Z

Thanks!

lilypond: add openlilylib-fonts and lilypond-with-fonts

bdc9589

yurrriq commented Mar 6, 2017

View reviewed changes

Mic92 reviewed Mar 6, 2017

View reviewed changes

lilypond-with-fonts: use all fonts by default

f497421

Add a list of all fonts to openlilylib-fonts and use that as the default fonts argument to lilypond-with-fonts.

Mic92 merged commit d971a9b into NixOS:master Mar 6, 2017

yurrriq deleted the update/pkgs/misc/lilypond/with-fonts branch March 6, 2017 22:12

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

lilypond: add openlilylib-fonts and lilypond-with-fonts #23548

lilypond: add openlilylib-fonts and lilypond-with-fonts #23548

yurrriq commented Mar 6, 2017 •

edited

yurrriq Mar 6, 2017

Mic92 Mar 6, 2017

yurrriq Mar 6, 2017

Mic92 Mar 6, 2017

yurrriq commented Mar 6, 2017

Mic92 Mar 6, 2017 •

edited

Mic92 commented Mar 6, 2017

		@@ -0,0 +1,28 @@
		{ stdenv, lilypond, lndir }: fonts: stdenv.mkDerivation {

lilypond: add openlilylib-fonts and lilypond-with-fonts #23548

lilypond: add openlilylib-fonts and lilypond-with-fonts #23548

Conversation

yurrriq commented Mar 6, 2017 • edited

Motivation for this change

Notes

Things done

yurrriq Mar 6, 2017

Choose a reason for hiding this comment

Mic92 Mar 6, 2017

Choose a reason for hiding this comment

yurrriq Mar 6, 2017

Choose a reason for hiding this comment

Mic92 Mar 6, 2017

Choose a reason for hiding this comment

yurrriq commented Mar 6, 2017

Mic92 Mar 6, 2017 • edited

Choose a reason for hiding this comment

Mic92 commented Mar 6, 2017

yurrriq commented Mar 6, 2017 •

edited

Mic92 Mar 6, 2017 •

edited