libqmlbind: init at 0.2.0 #23547
Closed
libqmlbind: init at 0.2.0 #23547
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you rename the commit title to match the pull request title? |
Mic92
reviewed
Mar 6, 2017
|
|
||
| src = fetchgit { | ||
| url = "https://github.com/seanchas116/libqmlbind"; | ||
| rev = "7ca90d1993934cd7748da7ed89484802290b9489"; |
There was a problem hiding this comment.
The following should also work here:
rev = "refs/tags/v${version}";
Mic92
reviewed
Mar 6, 2017
|
|
||
| meta = with stdenv.lib; { | ||
| homepage = https://github.com/seanchas116/libqmlbind; | ||
| description = "C bindings for QML, used for binding to other languages"; |
There was a problem hiding this comment.
license = with licenses; [ mit fdl13 ];
Do you want to maintain this package?
Mic92
reviewed
Mar 6, 2017
| preBuild = '' | ||
| pushd . | ||
| doxygen Doxyfile | ||
| popd |
There was a problem hiding this comment.
pushd . is a no-op here and can be removed.
Mic92
reviewed
Mar 7, 2017
| @@ -49,6 +48,6 @@ stdenv.mkDerivation rec { | |||
| homepage = https://github.com/seanchas116/libqmlbind; | |||
| description = "C bindings for QML, used for binding to other languages"; | |||
| license = with licenses; [ mit fdl13 ]; | |||
| maintainers = [ "0BobTheJanitor <Changing Email>" ] | |||
| maintainers = [ "0BobTheJanitor <Changing Email>" ]; | |||
There was a problem hiding this comment.
Could please an entry to lib/maintainers.nix instead and reference it here.
There was a problem hiding this comment.
I'm currently getting a new email and domain, but I can add it now and just update it later.
added 5 commits
March 27, 2017 17:21
|
I am going to switch to a different library, don't see the need to have this merged anymore |
ghost
closed this
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
C bindings for QtQuick, since a lot of programming languages have issues dealing with C++, and so is useful for writing Qt bindings to other languages. Not the highest priority package, since the only language I know that uses these bindings is Ruby, Swift (which I believe was abandoned), and my bindings for Crystal, but I thought I'd submit a pull request anyways.
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)