Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clog-cli: init at 0.9.2 #23551

Merged
merged 2 commits into from Mar 6, 2017
Merged

clog-cli: init at 0.9.2 #23551

merged 2 commits into from Mar 6, 2017

Conversation

nthorne
Copy link
Contributor

@nthorne nthorne commented Mar 6, 2017

Motivation for this change

To introduce the clog-cli changelog generation tool.

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

description = "Generate changelogs from local git metadata";
homepage = https://github.com/clog-tool/clog-cli;
license = stdenv.lib.licenses.mit;
platforms = stdenv.lib.platforms.linux;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you want to maintain this package?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That was the plan, yes.

Copy link
Member

@Mic92 Mic92 Mar 6, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, in this case you can add the following line:

meta = {
  # ...
  maintainers = [stdenv.lib.maintainers.nthorne];
};

and add an entry for your github username to lib/maintainers.nix

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As such?

Updated with maintainer information.
@Mic92 Mic92 merged commit 7576bea into NixOS:master Mar 6, 2017
@Mic92
Copy link
Member

Mic92 commented Mar 6, 2017

Thanks!

@nthorne nthorne deleted the clog-derivation branch March 6, 2017 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants