marathonctl: init at 2017-03-06 #23995
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manveru
force-pushed
the
add-marathonctl
branch
from
7899b8f
to
12e0349
Compare
manveru
changed the title
rycee
reviewed
Mar 17, 2017
| { stdenv, buildGoPackage, fetchFromGitHub }: | ||
|
|
||
| buildGoPackage rec { | ||
| name = "marathonctl-${version}"; |
There was a problem hiding this comment.
The name should be marathonctl-unstable-${version} since it is built from a checkout that isn't formally released.
There was a problem hiding this comment.
They don't have any stable releases anyway, but will fix it.
manveru
force-pushed
the
add-marathonctl
branch
from
12e0349
to
f97a821
Compare
|
Renamed to marathonctl-unstable. |
|
Pushed to master in 6cc1200. Many thanks for the contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)