Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix wrong -I in subcmd #61

Closed
wants to merge 2 commits into from
Closed

Fix wrong -I in subcmd #61

wants to merge 2 commits into from

Conversation

rurban
Copy link
Contributor

@rurban rurban commented Mar 13, 2017

create_config_file used wrong -I paths, leading to typical
Cwd.c: loadable library and perl binaries are mismatched
(got handshake key 0xd400000, needed 0xd300000)
loading completly mismatching modules.

create_config_file used wrong -I paths, leading to typical
Cwd.c: loadable library and perl binaries are mismatched
(got handshake key 0xd400000, needed 0xd300000)
loading completly mismatching modules.
@ingydotnet
Copy link
Owner

This patch was applied and dev released but it broke travis testing and so was
reverted. It seems the quoting and the system call form are not quite right.

@nrdvana
Copy link
Contributor

nrdvana commented Jun 23, 2018

@rurban Not sure how Travis differs from your environment, but here's what we got: https://travis-ci.org/ingydotnet/inline-pm/jobs/395716787#L464

It seems the arguments got passed directly to exec rather than evaluated by the shell.

@mohawk2
Copy link
Collaborator

mohawk2 commented Jun 23, 2018

This patch looks like it would never work, for the reasons stated by @nrdvana, and additionally like it would never be needed.

@mohawk2 mohawk2 closed this Jan 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants