Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fetch-*: remove md5 support #23838

Merged
merged 2 commits into from Mar 21, 2017
Merged

fetch-*: remove md5 support #23838

merged 2 commits into from Mar 21, 2017

Conversation

globin
Copy link
Member

@globin globin commented Mar 13, 2017

@mention-bot
Copy link

@globin, thanks for your PR! By analyzing the history of the files in this pull request, we identified @edolstra, @bennofs and @edwtjo to be potential reviewers.

@copumpkin
Copy link
Member

copumpkin commented Mar 13, 2017

Mostly okay (err, actually really happy) with this, but I might leave the parameter in place and add an assertion that it's empty, so we can throw a helpful error message ("we've removed md5 support from nixpkgs; please use sha256 from now on" or something) for a while, instead of just breaking it. Nix packages do exist outside of nixpkgs and I hate breaking things with no helpful errors.

@globin
Copy link
Member Author

globin commented Mar 20, 2017

@copumpkin updated

@globin globin merged commit c93eb74 into NixOS:master Mar 21, 2017
@globin globin deleted the remove-md5 branch March 21, 2017 12:27
@copumpkin
Copy link
Member

Awesome, thanks!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Get rid of md5 support for fixed-output derivations
6 participants