Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CB-251: Fix ISE on some place review pages. #88

Merged
merged 3 commits into from Mar 23, 2017

Conversation

ferbncode
Copy link
Member

Some places which may have a life_span attribute, may not have a begin (year) attribute. For example, see review: https://critiquebrainz.org/review/51fae187-b852-453c-9262-678b825ec31f.

{% if place['life-span'] %}
<small>{{ place['life-span']['begin'][:4] }}</small>
{% if place['life-span']['begin'] %}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can this if statement be combined with the one above?

@gentlecat gentlecat merged commit 59900bd into metabrainz:master Mar 23, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants