Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unclutter.service: prevent empty display value #23834

Closed
wants to merge 1 commit into from

Conversation

magnetophon
Copy link
Member

@magnetophon magnetophon commented Mar 13, 2017

I'm not sure what the root cause of the problem is, but this fixes unclutter for me.
If this is the proper solution, then please merge it in 17.03

  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@mention-bot
Copy link

@magnetophon, thanks for your PR! By analyzing the history of the files in this pull request, we identified @anderspapitto and @rnhmjoj to be potential reviewers.

@rnhmjoj
Copy link
Contributor

rnhmjoj commented Mar 13, 2017

config.services.xserver.display is defined here with a default value. I don't understand how it can be empty.

@joachifm
Copy link
Contributor

Closing. I think this is a symptom of the service being fundamentally broken so should be addressed at a different level.

@joachifm joachifm closed this Mar 19, 2017
@joachifm joachifm reopened this Apr 21, 2017
@joachifm joachifm closed this Apr 21, 2017
@joachifm
Copy link
Contributor

Ugh, sorry, misclick.

@magnetophon magnetophon deleted the unclutter branch June 6, 2020 22:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants