Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fetchSvn: Add support for --ignore-keywords flag #23830

Merged
merged 1 commit into from Mar 13, 2017

Conversation

Rotsor
Copy link
Contributor

@Rotsor Rotsor commented Mar 13, 2017

Motivation for this change

This is a flag that disables subversion keyword substitution.
Keyword substitution inserts metadata into the files being checked
out, and is therefore somewhat at odds with build reproducibility.

In particular, it can become a problem if you're trying to switch
between svn and a git export of the same thing (keyword substitutions
are normally not exported into git).

Things done

Used fetchGit and fetchSvn to fetch openttd. They produced different sha256 hashes initially, but they produce the same sha256 hash when I use ignoreKeywords

  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip" (says: Nothing changed)
  • (vacuously) Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

This is a flag that disables subversion keyword substitution.
Keyword substitution inserts metadata into the files being checked
out, and is therefore somewhat at odds with build reproducibility.

In particular, it can become a problem if you're trying to switch
between svn and a git export of the same thing (keyword substitutions
are normally not exported into git).
@mention-bot
Copy link

@Rotsor, thanks for your PR! By analyzing the history of the files in this pull request, we identified @edolstra, @nbp and @7c6f434c to be potential reviewers.

@7c6f434c 7c6f434c merged commit 777bc07 into NixOS:master Mar 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants