Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

salut-a-toi: 0.2.0 -> 0.6.1 #23999

Merged
merged 1 commit into from Mar 18, 2017
Merged

salut-a-toi: 0.2.0 -> 0.6.1 #23999

merged 1 commit into from Mar 18, 2017

Conversation

ndowens
Copy link
Contributor

@ndowens ndowens commented Mar 18, 2017

Motivation for this change

Update

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@mention-bot
Copy link

@ndowens, thanks for your PR! By analyzing the history of the files in this pull request, we identified @FRidh, @7c6f434c and @aske to be potential reviewers.

salut-a-toi: Removed un-needed python variable in function
@FRidh
Copy link
Member

FRidh commented Mar 18, 2017

Is there a reason this package doesn't use buildPythonApplication?

@7c6f434c
Copy link
Member

If I remember correctly, I was initially mass-packaging IM stuff and this was before buildPythonApplication

@7c6f434c 7c6f434c merged commit 54aff5c into NixOS:master Mar 18, 2017
@ndowens ndowens deleted the salut-a-toi branch March 20, 2017 22:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants