Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

firefox, firefox-bin: 52.0 -> 52.0.1, firefox-esr: 52.0esr -> 52.0.1esr [Critical security fix] #24000

Merged
merged 2 commits into from Mar 18, 2017

Conversation

taku0
Copy link
Contributor

@taku0 taku0 commented Mar 18, 2017

Motivation for this change
Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

firefox-bin is tested. firefox and firefox-esr are still building.


@mention-bot
Copy link

@taku0, thanks for your PR! By analyzing the history of the files in this pull request, we identified @edolstra, @vcunat and @wkennington to be potential reviewers.

@joachifm joachifm merged commit 5d51f1d into NixOS:master Mar 18, 2017
@taku0
Copy link
Contributor Author

taku0 commented Mar 18, 2017

24,000th issue!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants