Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

spambayes: Add bsddb3 build input #24009

Merged
merged 1 commit into from Mar 18, 2017
Merged

Conversation

stebulus
Copy link
Contributor

To reproduce the issue:

nix-build -E 'import <nixpkgs> {}' -A python27Packages.spambayes
result/bin/sb_filter.py </dev/null

Before this commit, this fails with

[...]
  File "/nix/store/vlgr1wrxd2wiw5ay5ch54365dzqvcwgq-python2.7-spambayes-1.1b1/lib/python2.7/site-packages/spambayes/dbmstorage.py", line 20, in open_dbhash
    return bsddb.hashopen(*args)
AttributeError: 'NoneType' object has no attribute 'hashopen'

After this commit, it doesn't.

Motivation for this change
Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

To reproduce the issue:
```
nix-build -E 'import <nixpkgs> {}' -A python27Packages.spambayes
result/bin/sb_filter.py </dev/null
```
Before this commit, this fails with
```
[...]
  File "/nix/store/vlgr1wrxd2wiw5ay5ch54365dzqvcwgq-python2.7-spambayes-1.1b1/lib/python2.7/site-packages/spambayes/dbmstorage.py", line 20, in open_dbhash
    return bsddb.hashopen(*args)
AttributeError: 'NoneType' object has no attribute 'hashopen'
```
After this commit, it doesn't.
@mention-bot
Copy link

@stebulus, thanks for your PR! By analyzing the history of the files in this pull request, we identified @FRidh to be a potential reviewer.

@7c6f434c 7c6f434c merged commit 5acc9ee into NixOS:master Mar 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants