slimserver: Init at 7.9.0 (pkg + module) #24008
Conversation
|
@phile314, thanks for your PR! By analyzing the history of the files in this pull request, we identified @edolstra, @joachifm and @offlinehacker to be potential reviewers. |
nixos/modules/misc/ids.nix
Outdated
| @@ -288,6 +288,7 @@ | |||
| kresd = 270; | |||
| rpc = 271; | |||
| geoip = 272; | |||
| slimserver = 273; | |||
There was a problem hiding this comment.
I didn't know about dynamic ids yet. Maybe it would make sense to put a comment in the ids file that dynamic ids are available? Best placed at the end of the list where one would add a new entry?
There was a problem hiding this comment.
It should probably be made clearer why one might want to use static ids, at any rate; it's probably heavily overused as-is, leading to the impression that it's required.
There was a problem hiding this comment.
I thought that if it has non-transient state, it should be static UID?
There was a problem hiding this comment.
slimserver definitely has non-transient state (settings, music library metadata). So should I use a static UID?
|
OK, looks good enough, and isolated enough, so that merging instead of forgetting seems net-positive regardless of what's going on with the service… |
Motivation for this change
Add slimserver package + module. Slimserver is the audio server for the Logitech Squeezebox products.
I have used this PR in my personal setup for the last few days and everything works fine.
I will squash the commits once it's merge ready.
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)