vogl: init at 2016-05-13 #24002

deepfire · 2017-03-18T03:00:08Z

Motivation for this change

Packaging https://github.com/ValveSoftware/vogl --

Things done

Tested using sandboxing
(nix.useSandbox on NixOS,
or option build-use-sandbox in nix.conf
on non-NixOS)
Built on platform(s)
- NixOS
- macOS
- Linux (SteamOS)
Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
Tested execution of all binary files (usually in ./result/bin/)
Fits CONTRIBUTING.md.

--

Things work, modulo two issues:

libGL not working on non-NixOS (without setting up) #9415 -- for which there now is a partial solution: https://github.com/deepfire/nix-install-vendor-gl
you need to tick the Use vogl tool checkbox in the Generate trace.. dialog -- no idea about that yet.

deepfire · 2017-03-18T03:01:02Z

This almost works on Nix/SteamOS. Haven't managed to make it reliable yet, though.

ndowens · 2017-03-18T22:31:20Z

pkgs/development/tools/vogl/default.nix

+  name = "vogl-${ver}";
+  version = "${ver}";
+
+  src = fetchgit {


Should use fetchFromGitHub

ndowens · 2017-03-18T22:31:40Z

pkgs/development/tools/vogl/default.nix

+    makeQtWrapper pkgconfig
+  ];
+
+  buildInputs = [


cmake also goes in nativeBuildInputs

ndowens · 2017-03-18T22:32:19Z

pkgs/development/tools/vogl/default.nix

+    description = "OpenGL capture / playback debugger.";
+    homepage = https://github.com/ValveSoftware/vogl;
+    license = licenses.bsd3;
+    maintainers = with maintainers; [ deepfire ];


If there is only one maintainer, should be maintainers = [ maintainers.deepfire ];

ndowens · 2017-03-18T22:32:54Z

pkgs/development/tools/vogl/default.nix

+  ];
+
+  buildInputs = [
+    cmake git pkgconfig wget zip


pkgconfig is already in nativeBuildInputs, shouldn't be in buildInputs as well

deepfire · 2017-03-19T00:17:44Z

@ndowens, updated my journal..

ndowens · 2017-03-19T00:21:16Z

Currently qt5base is messed up atm, does qt4 work on this package?

deepfire · 2017-03-19T00:38:36Z

@ndowens, no idea, but seems unlikely.. the qt5-based vogleditor64 binary runs fine here, though.

deepfire · 2017-03-19T02:58:47Z

@ndowens, there's a build failure that ends with:

error: a ‘aarch64-linux’ is required to build ‘/nix/store/2ssy7xzn086xdbb5lpwhg611ksbmmmvr-options-db.xml.drv’, but I am a ‘x86_64-linux’

I'm not sure what to make of it..

ndowens · 2017-03-19T03:00:58Z

Taking a look at it. Idk if I will be able to try and fix it tonight though

deepfire · 2017-03-19T03:03:47Z

@ndowens, I have restricted platforms to intel linux -- let's see if this fixes it.

ndowens · 2017-03-19T03:04:39Z

You are still using qt5 which fails

edit: might not have refreshed yet for me.
edit2: It wasn't refreshing for me when I made that comment; So I have pulled the copy and it is currently building; will update when I can, it is late here

Mic92 · 2017-03-19T19:43:59Z

pkgs/development/tools/vogl/default.nix

+    description = "OpenGL capture / playback debugger.";
+    homepage = https://github.com/ValveSoftware/vogl;
+    license = licenses.bsd3;
+    maintainers = maintainers.deepfire;


maintainers = [maintainers.deepfire];

deepfire · 2017-03-19T20:12:14Z

@Mic92, fixed, thanks!

deepfire · 2017-03-19T21:45:30Z

@ndowens, how does the qt5base problem manifest itself? Better yet -- what is the issue #? : -)

deepfire · 2017-03-21T13:39:39Z

The qt version issue was resolved - the following seems to be odd:

builder for ‘/nix/store/4hz579lfl90ja8kyq2nvbp2rahvcx68f-nixpkgs-tarball-17.09pre1234.abcdef.drv’ failed with exit code 137

error: build of ‘/nix/store/4hz579lfl90ja8kyq2nvbp2rahvcx68f-nixpkgs-tarball-17.09pre1234.abcdef.drv’ failed

The command "./maintainers/scripts/travis-nox-review-pr.sh nixpkgs-verify nixpkgs-manual nixpkgs-tarball nixpkgs-unstable" exited with 100.

deepfire · 2017-03-21T13:54:50Z

@ndowens, I have fixed the issue -- thanks to ttuegel, who helped me realise that the underlying version of qt5 has changed under the feet -- which explained why it built for me on the older version of nixpkgs.

deepfire · 2017-03-22T09:50:39Z

The issue we're hitting is #24200

Mic92 · 2017-03-23T08:50:13Z

looks fine to except that one shared object is located in bin:

$ find /nix/store/cjb971c4k5jkzrcrav59z9grljlvgdln-vogl-2016-05-13
/nix/store/cjb971c4k5jkzrcrav59z9grljlvgdln-vogl-2016-05-13
/nix/store/cjb971c4k5jkzrcrav59z9grljlvgdln-vogl-2016-05-13/nix-support
/nix/store/cjb971c4k5jkzrcrav59z9grljlvgdln-vogl-2016-05-13/nix-support/propagated-native-build-inputs
/nix/store/cjb971c4k5jkzrcrav59z9grljlvgdln-vogl-2016-05-13/bin
/nix/store/cjb971c4k5jkzrcrav59z9grljlvgdln-vogl-2016-05-13/bin/voglgen64
/nix/store/cjb971c4k5jkzrcrav59z9grljlvgdln-vogl-2016-05-13/bin/vogltest64
/nix/store/cjb971c4k5jkzrcrav59z9grljlvgdln-vogl-2016-05-13/bin/libvogltrace64.so # <- that guy looks suspicious
/nix/store/cjb971c4k5jkzrcrav59z9grljlvgdln-vogl-2016-05-13/bin/voglbench64
/nix/store/cjb971c4k5jkzrcrav59z9grljlvgdln-vogl-2016-05-13/bin/vogleditor64
/nix/store/cjb971c4k5jkzrcrav59z9grljlvgdln-vogl-2016-05-13/bin/vogl64
/nix/store/cjb971c4k5jkzrcrav59z9grljlvgdln-vogl-2016-05-13/bin/ktxtool64
/nix/store/cjb971c4k5jkzrcrav59z9grljlvgdln-vogl-2016-05-13/bin/glxspheres64

deepfire · 2017-03-23T11:32:12Z

@Mic92, that is by design -- the program assumes this location and breaks when it is located elsewhere.

deepfire · 2017-03-24T01:23:39Z

Squashed, as per @ndowens suggestion.

deepfire · 2017-03-24T03:30:41Z

@Mic92, @ndowens deferred the judgement on this PR to you.

deepfire · 2017-03-26T07:41:46Z

Alright, now it works on SteamOS as well!

The only quirk is the requirement to tick the Use vogl tool checkbox during trace capture.

FRidh · 2017-03-26T08:01:58Z

pkgs/development/tools/vogl/default.nix

+, freeglut, mesa, mesa_glu
+}:
+let
+  ver = "2016-05-13";


why not call this version right away?

deepfire · 2017-03-26T08:13:10Z

@FRidh, done!

deepfire force-pushed the vogl branch from e102444 to dd9d6ba Compare March 18, 2017 19:53

ndowens suggested changes Mar 18, 2017

View reviewed changes

deepfire force-pushed the vogl branch from 3d2e3d6 to e5bde92 Compare March 19, 2017 00:03

Mic92 reviewed Mar 19, 2017

View reviewed changes

deepfire force-pushed the vogl branch from f0b1ae0 to adcc31a Compare March 19, 2017 21:58

deepfire mentioned this pull request Mar 21, 2017

qt5base-induced failures in nixpkgs master #24144

Closed

deepfire force-pushed the vogl branch from adcc31a to 19e4a83 Compare March 21, 2017 13:10

deepfire force-pushed the vogl branch 2 times, most recently from b5b0b9f to 2b60c03 Compare March 22, 2017 08:14

deepfire force-pushed the vogl branch from 2b60c03 to fe5bd3f Compare March 24, 2017 01:19

deepfire force-pushed the vogl branch from fe5bd3f to ce2d1c0 Compare March 25, 2017 02:56

FRidh reviewed Mar 26, 2017

View reviewed changes

deepfire force-pushed the vogl branch from ce2d1c0 to c670a19 Compare March 26, 2017 08:12

vogl: init at 2016-05-13

03ddb41

deepfire force-pushed the vogl branch from c670a19 to 03ddb41 Compare March 26, 2017 08:16

Mic92 merged commit 09c91f5 into NixOS:master Mar 26, 2017

deepfire deleted the vogl branch March 26, 2017 17:20

deepfire mentioned this pull request Mar 26, 2017

No release ValveSoftware/vogl#217

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

vogl: init at 2016-05-13 #24002

vogl: init at 2016-05-13 #24002

deepfire commented Mar 18, 2017 •

edited

deepfire commented Mar 18, 2017

ndowens Mar 18, 2017

deepfire Mar 19, 2017

ndowens Mar 18, 2017

ndowens Mar 18, 2017

ndowens Mar 18, 2017

deepfire commented Mar 19, 2017

ndowens commented Mar 19, 2017

deepfire commented Mar 19, 2017 •

edited

deepfire commented Mar 19, 2017

ndowens commented Mar 19, 2017

deepfire commented Mar 19, 2017

ndowens commented Mar 19, 2017 •

edited

Mic92 Mar 19, 2017 •

edited

deepfire commented Mar 19, 2017

deepfire commented Mar 19, 2017 •

edited

deepfire commented Mar 21, 2017

deepfire commented Mar 21, 2017

deepfire commented Mar 22, 2017

Mic92 commented Mar 23, 2017 •

edited

deepfire commented Mar 23, 2017

deepfire commented Mar 24, 2017

deepfire commented Mar 24, 2017

deepfire commented Mar 26, 2017 •

edited

FRidh Mar 26, 2017

deepfire commented Mar 26, 2017

vogl: init at 2016-05-13 #24002

vogl: init at 2016-05-13 #24002

Conversation

deepfire commented Mar 18, 2017 • edited

Motivation for this change

Things done

deepfire commented Mar 18, 2017

ndowens Mar 18, 2017

Choose a reason for hiding this comment

deepfire Mar 19, 2017

Choose a reason for hiding this comment

ndowens Mar 18, 2017

Choose a reason for hiding this comment

ndowens Mar 18, 2017

Choose a reason for hiding this comment

ndowens Mar 18, 2017

Choose a reason for hiding this comment

deepfire commented Mar 19, 2017

ndowens commented Mar 19, 2017

deepfire commented Mar 19, 2017 • edited

deepfire commented Mar 19, 2017

ndowens commented Mar 19, 2017

deepfire commented Mar 19, 2017

ndowens commented Mar 19, 2017 • edited

Mic92 Mar 19, 2017 • edited

Choose a reason for hiding this comment

deepfire commented Mar 19, 2017

deepfire commented Mar 19, 2017 • edited

deepfire commented Mar 21, 2017

deepfire commented Mar 21, 2017

deepfire commented Mar 22, 2017

Mic92 commented Mar 23, 2017 • edited

deepfire commented Mar 23, 2017

deepfire commented Mar 24, 2017

deepfire commented Mar 24, 2017

deepfire commented Mar 26, 2017 • edited

FRidh Mar 26, 2017

Choose a reason for hiding this comment

deepfire commented Mar 26, 2017

deepfire commented Mar 18, 2017 •

edited

deepfire commented Mar 19, 2017 •

edited

ndowens commented Mar 19, 2017 •

edited

Mic92 Mar 19, 2017 •

edited

deepfire commented Mar 19, 2017 •

edited

Mic92 commented Mar 23, 2017 •

edited

deepfire commented Mar 26, 2017 •

edited