feh: 2.18.1 -> 2.18.2 #24028
Merged
feh: 2.18.1 -> 2.18.2 #24028
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rycee
reviewed
Mar 19, 2017
| stdenv.mkDerivation rec { | ||
| name = "feh-2.18.1"; | ||
| name = "feh-${version}"; | ||
| version = "2.18.2"; |
There was a problem hiding this comment.
The version field doesn't seem to be used anywhere else so simpler to just leave it directly in the name.
rycee
reviewed
Mar 19, 2017
| --add-flags '--theme=feh' | ||
| ''; | ||
| --add-flags '--theme=feh' | ||
| ''; |
rycee
reviewed
Mar 19, 2017
|
|
||
| buildInputs = [ xorg.libX11 xorg.libXinerama imlib2 libjpeg libpng curl libexif ]; | ||
|
|
||
| preBuild = '' | ||
| makeFlags="PREFIX=$out exif=1" | ||
| ''; | ||
|
|
||
| libPath = makeLibraryPath ([ imlib2 curl xorg.libXinerama libjpeg libpng libexif xorg.libX11 ]); |
There was a problem hiding this comment.
I don't think the parentheses do anything here. Should work fine without them.
rycee
reviewed
Mar 19, 2017
|
|
||
| buildInputs = [ xorg.libX11 xorg.libXinerama imlib2 libjpeg libpng curl libexif ]; | ||
|
|
||
| preBuild = '' | ||
| makeFlags="PREFIX=$out exif=1" | ||
| ''; | ||
|
|
||
| libPath = makeLibraryPath ([ imlib2 curl xorg.libXinerama libjpeg libpng libexif xorg.libX11 ]); |
There was a problem hiding this comment.
I'm a bit curious why the libPath field is required here. Did something change in 2.18.2 to need it or was there a problem with earlier versions as well?
|
Umm, I would have appreciated some response to my comments. |
|
It was attempt to fix it not finding that lib |
|
I will update it later think I know how to fix it now |
|
Sry didn't see msg |
|
No worries. |
ndowens
commented
Mar 21, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Update
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)