LLVM 3.9 improvements #24018
Merged
LLVM 3.9 improvements #24018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@copumpkin, thanks for your PR! By analyzing the history of the files in this pull request, we identified @pmahoney, @pSub, @pmiddend and @FRidh to be potential reviewers. |
|
Err, I should've based this off staging. |
Splits outputs in clang like we do in 3.8 and 4.0 to avoid runtime dependency on Python in the main derivation. I also disable TSAN on Darwin to maintain consistency with 4.0, which disables it because it forces an unfree dependency in the stdenv.
copumpkin
force-pushed
the
llvm-39-improvements
branch
from
5474fb0
to
f3aeb3b
Compare
|
Would it be appropriate/neater to use |
|
Oh, I didn't even know about that! |
|
Note that it supports wildcards (but you have to quote them so they're not destroyed by bash immediately). |
LnL7
approved these changes
Mar 19, 2017
|
Going to merge this for now and then switch all the LLVM expressions to use |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Splits outputs in clang like we do in 3.8 and 4.0 to avoid runtime dependency on Python in the main derivation output.
I also disable TSAN on Darwin to maintain consistency with 4.0, which disables it because it forces an unfree dependency in the stdenv.
Motivation for this change
Closure size and consistency with 4.0
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)