Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

istringstream_nocopy: Implement in a standards-compliant way. #1263

Merged
merged 1 commit into from Mar 21, 2017

Conversation

shlevy
Copy link
Member

@shlevy shlevy commented Mar 6, 2017

Fixes the problem mentioned in e6a61b8

See #1135

@shlevy
Copy link
Member Author

shlevy commented Mar 6, 2017

s3 access doesn't seem to completely work on darwin yet, but this gets further...

@shlevy
Copy link
Member Author

shlevy commented Mar 6, 2017

And anyway on linux the current code is broken against libc++

@shlevy
Copy link
Member Author

shlevy commented Mar 6, 2017

@edolstra @copumpkin

@edolstra
Copy link
Member

edolstra commented Mar 6, 2017

That's a lot of code for a little performance optimization :-(

@shlevy
Copy link
Member Author

shlevy commented Mar 6, 2017

C++ streams considered verbose 😦

@copumpkin
Copy link
Member

Do we really need the full stream interface? Agree that it's awkwardly verbose but if we're using them in a non-standards compliant manner, they kind of work "by accident" and could break with future updates.

@shlevy
Copy link
Member Author

shlevy commented Mar 6, 2017

We're passing this to the aws sdk, which does expect a proper stream. And indeed on libc++ our current impl is broken due to broken compliance :(

@shlevy
Copy link
Member Author

shlevy commented Mar 7, 2017

If it helps, a lot of the verbosity is just boilerplate 👅

@shlevy
Copy link
Member Author

shlevy commented Mar 8, 2017

@edolstra ping

@shlevy
Copy link
Member Author

shlevy commented Mar 16, 2017

@edolstra Do we want to merge this, drop the optimization all together, or drop S3 support on libc++ based builds?

@edolstra edolstra merged commit 4fc3092 into NixOS:master Mar 21, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants