Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

emem: 0.2.29 -> 0.2.30 #23558

Closed
wants to merge 1 commit into from
Closed

emem: 0.2.29 -> 0.2.30 #23558

wants to merge 1 commit into from

Conversation

ebzzry
Copy link

@ebzzry ebzzry commented Mar 6, 2017

Motivation for this change
Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@Mic92
Copy link
Member

Mic92 commented Mar 6, 2017

When trying to convert README.md of nixpkgs I get the following error:

emem /etc/nixos/nixpkgs/README.md                 
Exception in thread "main" java.io.FileNotFoundException: /nix/store/sgyq67jncfnxz2pspvabcryhwqp2piya-emem-0.2.30/static/css/tomorrow.css (No such file or directory)
        at java.io.FileOutputStream.open0(Native Method)
        at java.io.FileOutputStream.open(FileOutputStream.java:270)
        at java.io.FileOutputStream.<init>(FileOutputStream.java:213)
        at java.io.FileOutputStream.<init>(FileOutputStream.java:162)
        at clojure.java.io$fn__9558.invokeStatic(io.clj:319)
        at clojure.java.io$fn__9558.invoke(io.clj:319)
        at clojure.lang.MultiFn.invoke(MultiFn.java:238)
        at clojure.java.io$copy.invokeStatic(io.clj:406)
        at clojure.java.io$copy.doInvoke(io.clj:391)
        at clojure.lang.RestFn.invoke(RestFn.java:425)
        at emem.util$copy_resources$f__905.invoke(util.clj:454)
        at emem.util$with_resources.invokeStatic(util.clj:404)
        at emem.util$with_resources.invoke(util.clj:398)
        at emem.util$copy_resources.invokeStatic(util.clj:455)
        at emem.util$copy_resources.doInvoke(util.clj:428)
        at clojure.lang.RestFn.invoke(RestFn.java:410)
        at emem.core$dump.invokeStatic(core.clj:230)
        at emem.core$dump.invoke(core.clj:207)
        at emem.core$_main.invokeStatic(core.clj:295)
        at emem.core$_main.doInvoke(core.clj:285)
        at clojure.lang.RestFn.applyTo(RestFn.java:137)
        at emem.core.main(Unknown Source)

Are the stylesheets missing here?

@ebzzry
Copy link
Author

ebzzry commented Mar 6, 2017

@Mic92 That’s odd—the static/ dir shouldn’t be there. What does the following command return?

ls $(nix-env --query --out-path emem | awk '{print $2}')

fpletz
fpletz approved these changes Mar 6, 2017
View reviewed changes
Copy link
Member

@fpletz fpletz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also tested with README.md from nixpkgs. Works for me.

Though I used nix-build and invoked it like ./result/bin/emem README.md.

@ebzzry
Copy link
Author

ebzzry commented Mar 7, 2017

#23576 is a newer PR

@grahamc
Copy link
Member

grahamc commented Mar 7, 2017

Merged newer Pr in d6192e9.

@grahamc grahamc closed this Mar 7, 2017
@ebzzry ebzzry deleted the emem-0.2.30 branch March 14, 2017 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fpletz fpletz fpletz approved these changes

Assignees
No one assigned
Labels
8.has: package (update)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ebzzry @Mic92 @grahamc @fpletz