Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AB-290 Viewing the recording information of a dataset or a snapshot requires being logged in #227

Closed
wants to merge 3 commits into from

Conversation

nupurbaghel
Copy link
Contributor

Auth-Login removed to view recording details from datasets
The ticket was - Viewing the recording information of a dataset or a snapshot requires being logged in
https://tickets.metabrainz.org/browse/AB-290

@mineo
Copy link
Member

mineo commented Mar 8, 2017

(I'm only the reporter of https://tickets.metabrainz.org/browse/AB-290, not a developer on this repository).

Instead of commenting out the decorator, you can just remove the line, the history of the file will show that at some point in the past this required logging in.

@alastair alastair self-assigned this Mar 13, 2017
@nupurbaghel nupurbaghel changed the title Corrected: Viewing the recording information of a dataset or a snapshot requires being logged in AB-290 Viewing the recording information of a dataset or a snapshot requires being logged in Mar 14, 2017
@alastair
Copy link
Collaborator

You seem to be pushing multiple commits for different tasks to the same branch. Please be careful about creating a new branch for each task that you do.

@nupurbaghel
Copy link
Contributor Author

That was an error, as I created the PR from my master branch. Should i delete this pull request and create another one ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants