sublime3: fix hardcoded /bin/bash when executing commands for build systems #23561
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
exec.py in Default.package-sublime calls /bin/bash with subprocess. See Issue NixOS#12011. Because of this builds could not be started from withtin Sublime Text.
Without the wrapped version of bash (a symlink to $bash/bin/bash) with LD_PRELOAD to glibc an relocation error occurs when trying to run builds from within Sublime Text 3. See Issue NixOS#12011.
Mic92
reviewed
Mar 6, 2017
| ${unzip}/bin/unzip ../Packages/Default.sublime-package > /dev/null | ||
| substituteInPlace "exec.py" --replace \ | ||
| '["/bin/bash"' \ | ||
| '["/usr/bin/env", "bash"' |
There was a problem hiding this comment.
how about?
substituteInPlace "exec.py" --replace \
'["/bin/bash"' \
'["${pkgs.bash}/bin/bash"'
There was a problem hiding this comment.
Just noticed that you have already revert this change.
Mic92
reviewed
Mar 6, 2017
| '["/bin/bash"' \ | ||
| '["/usr/bin/env", "bash"' | ||
| "[\"/bin/bash\"" \ | ||
| "[\"$out/sublime_bash\"" |
There was a problem hiding this comment.
Would not my solution has the same effect?
There was a problem hiding this comment.
So is this fine? As you've said, It's already revised in the second commit.
|
Is there any issue with this? Can this be merged? |
|
Thanks! |
globin
pushed a commit
that referenced
this pull request
Mar 15, 2017
…ystems (#23561) * sublime3: replace hardcoded /bin/bash with /usr/bin/env exec.py in Default.package-sublime calls /bin/bash with subprocess. See Issue #12011. Because of this builds could not be started from withtin Sublime Text. * sublime3: use wrapped of bash to fix internal build system Without the wrapped version of bash (a symlink to $bash/bin/bash) with LD_PRELOAD to glibc an relocation error occurs when trying to run builds from within Sublime Text 3. See Issue #12011. (cherry picked from commit 1893ed5)
peterhoeg
pushed a commit
to peterhoeg/nixpkgs
that referenced
this pull request
Mar 16, 2017
…ystems (NixOS#23561) * sublime3: replace hardcoded /bin/bash with /usr/bin/env exec.py in Default.package-sublime calls /bin/bash with subprocess. See Issue NixOS#12011. Because of this builds could not be started from withtin Sublime Text. * sublime3: use wrapped of bash to fix internal build system Without the wrapped version of bash (a symlink to $bash/bin/bash) with LD_PRELOAD to glibc an relocation error occurs when trying to run builds from within Sublime Text 3. See Issue NixOS#12011.
Mic92
pushed a commit
that referenced
this pull request
Jun 1, 2017
…ystems (#23561) * sublime3: replace hardcoded /bin/bash with /usr/bin/env exec.py in Default.package-sublime calls /bin/bash with subprocess. See Issue #12011. Because of this builds could not be started from withtin Sublime Text. * sublime3: use wrapped of bash to fix internal build system Without the wrapped version of bash (a symlink to $bash/bin/bash) with LD_PRELOAD to glibc an relocation error occurs when trying to run builds from within Sublime Text 3. See Issue #12011. (cherry picked from commit 1893ed5)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
See Issue #12011. You can now run Builds from within Sublime Text.
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)