Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mendeley: 1.16.3 -> 1.17.8, multiple improvements #23563

Merged
merged 1 commit into from Mar 7, 2017
Merged

mendeley: 1.16.3 -> 1.17.8, multiple improvements #23563

merged 1 commit into from Mar 7, 2017

Conversation

dtzWill
Copy link
Member

@dtzWill dtzWill commented Mar 6, 2017

  • don't use bundled qt
  • fix link-handler script, autorun as 'normal'
  • fix execution on grsec kernels
Motivation for this change
Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@dtzWill
mendeley: 1.16.3 -> 1.17.8, multiple improvements
37315d6 
* don't use bundled qt
* fix link-handler script, autorun as 'normal'
* fix execution on grsec kernels
@mention-bot
Copy link

@dtzWill, thanks for your PR! By analyzing the history of the files in this pull request, we identified @badi, @vcunat and @FRidh to be potential reviewers.

@FRidh
Copy link
Member

FRidh commented Mar 7, 2017

I made an attempt using the bundled Qt but didn't get it to work #21093.

@FRidh FRidh merged commit b5355c8 into NixOS:master Mar 7, 2017
@FRidh FRidh mentioned this pull request Mar 7, 2017
Closed
7 tasks
@dtzWill dtzWill deleted the update/mendeley branch March 7, 2017 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: qt/kde 8.has: package (update)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dtzWill @mention-bot @FRidh