Fix 3988 #4094
Closed
Fix 3988 #4094
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
February 24, 2017 17:53
expand them when calling initializers
|
Similar idea done in a82ef1b |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves some scenarios regarding instance variables initializers.
The solution is a workaround that collect & expand later the initializers.
A better long term solution would be to decouple analyze ivar initializers and the instantiation of
#initializemethods. Like adding a phase that will remove syntactic ivar initializers in the class lexical scope and expand them in the initialize body, before the codegen. Hence in the codegen or further phases there is no need to track the concept of ivar initializers since they could be just a syntax sugar. NB: currently (before PR) ivar initializers are used in#allocateas well.Fixes #3988