buildbot: 0.9.3 -> 0.9.4 #23338
Merged
buildbot: 0.9.3 -> 0.9.4 #23338
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
nand0p
commented
Mar 1, 2017
•
nand0p
commented
- adds jwt
- adds module tests
- master.cfg as path in module
- eliminates worker timeout
- builds on darwin
- tested on nixos
nand0p
force-pushed
the
buildbot-0.9.4
branch
2 times, most recently
from
411733f
to
7c746c3
Compare
copumpkin
reviewed
Mar 3, 2017
| default = null; | ||
| example = "BuildmasterConfig = c = {}"; | ||
| example = /etc/nixos/buildbot/master.cfg; |
There was a problem hiding this comment.
You'll want this to be quoted if it's an example, otherwise Nix will try to find this file when it evaluates the example (mostly when we build documentation)
nand0p
force-pushed
the
buildbot-0.9.4
branch
5 times, most recently
from
75e7651
to
d49d280
Compare
FRidh
requested changes
Mar 4, 2017
| @@ -70,7 +71,7 @@ pythonPackages.buildPythonApplication (rec { | |||
| homepage = http://buildbot.net/; | |||
| description = "Continuous integration system that automates the build/test cycle"; | |||
| maintainers = with maintainers; [ nand0p ryansydnor ]; | |||
| platforms = platforms.linux; | |||
| platforms = platforms.all; | |||
There was a problem hiding this comment.
don't set it to all, buildPythonPackage will set the right value.
- adds jwt - adds module tests - master.cfg as path in module - fix systemd worker config - builds on darwin - tested on nixos
|
@FRidh @copumpkin ready_for_review |
FRidh
approved these changes
Mar 6, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.